Close #63 Allow --config-file option in mkdocs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great @fgrbr , thanks ! Could you please also add a line in the changelog ? You need to pull from Optional: if you see an easy way to test this feature against non-regression, do not hesitate to add a test to this PR ! This would probably imply creating a mock object and injecting a fake config with the various path flavours inside. |
|
Thanks for the quick response ! I've added a line to changelog and fixed a typo. Unfortunately, my python skills are not good enough to add a useful test for mocking the different paths. Sorry. |
smarie
approved these changes
May 15, 2023
|
Thanks @fgrbr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the path to the mkdocs config-file to be relative and not only absolute.