Add a scraper for pyvista #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work, should I add a line to the 0.8.0 section of the changelog file or create a section 0.8.1 ? |
|
Thanks @Louis-Pujol ! Yes, please create a new changelog section (0.9.0) with this item. This feature is significant enough to modify the minor version number and not the patch version number :) |
|
Ok I do that. In the meantine, I had also work on the following :
Would you prefer me to create new PRs for these changes, or to merge them directly here ? |
|
Thanks ! No, please Create distinct PRs, that will be easier to review |
smarie
reviewed
Dec 21, 2023
|
0.9.0 released with your contribution : https://smarie.github.io/mkdocs-gallery/generated/gallery/plot_11_pyvista/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ! I create a new PR as I forked again the project after some troubles with conflicting versions of the code.
In this PR I propose an implementation of a scraper for the pyvista library.
The scraper is a slight modification of the pyvista's sphinx-gallery scraper. I integrated it following the mayavi scraper already implemented.
It allows to show static or animated 3d scenes created with pyvista. I added an example to the examples gallery. I moved the definition of image_scrapers from mkdocs.yml to gallery_conf.py. I found this clearer as pyvista is configured in gallery_conf.py.
I also added pyvista as a dependency in MKDOCS_GALLERY_EXAMPLES_REQS in noxfile.py.