Examples folder outside of docs/ #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to be able to find locations that are not subpath of dir path (path starting by `../`)
|
Hi @Louis-Pujol , now that 0.10.0 is out you can probably update to latest HEAD. We'll try to integrate this in next release |
|
Hi @smarie ! Sure, I think this is fine now. Tell me if it is not the case. |
|
Thanks @Louis-Pujol ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request fixes #54
Examples folder could not be located outside of documentation folder. This was due to the use of the function
PurePath.relative_tofrom thepathliblibrary : by defaultrelative_toexplores subpaths of the requested path. A solution is to useos.path.relpath, which is able to find paths starting with../In this PR, the aforementioned modification is done in
plugin.pyand theexamples/folder is moved outside ofdocs/to illustrate this possibility.changelog.mdentries in the appropriate "in progress" section (not the last release one)