feat: Add tests for type info #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
smarie
reviewed
Mar 1, 2022
smarie
reviewed
Mar 1, 2022
smarie
reviewed
Mar 1, 2022
smarie
reviewed
Mar 1, 2022
smarie
reviewed
Mar 1, 2022
|
Great @last-partizan , thanks so much for sticking to this ! I made a few comments, small details / maintainability topics mostly |
smarie
reviewed
Mar 1, 2022
last-partizan
force-pushed
the
22-tests
branch
4 times, most recently
from
0eea523
to
cfff747
Compare
|
Huh, i've got somewhat distracted by Russians invading my country and forgot about this PR :) Now let's get to work! |
last-partizan
commented
May 18, 2022
last-partizan
commented
May 18, 2022
smarie
reviewed
May 19, 2022
smarie
reviewed
May 19, 2022
smarie
reviewed
May 19, 2022
|
Thanks a lot @last-partizan for this great PR ! I have a few comments concerning the way pyright is installed, see details in the files diff. However otherwise it looks really good ! (I hope that you and your relatives are safe. Terrible times...) Note that I'll be away next week so sorry if there are delays in reviewing the next round. |
|
Everything ready! |
|
Thanks @last-partizan ! Sorry for the wait... (And on a side note I hope everything is ok with you and relatives wrt the war) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I added tests using pyright and pytest plugin for snapshot testing syrupy. It allows us not to hardcode expected data in test, but to have it separated in snapshot files.
Those tests are running only on python 3.7+, other versions aren't supported, so I added
pytest.mark.skipif, which could be removed after next major version and dropping everything below 3.7.Right now pyright is checking that there is no errors in unexpected places, and errors in expected places.