Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --name option to change badge left side text #25
Add --name option to change badge left side text #25
Changes from 9 commits
5bf5fd9
840eb99
1569c48
8434aa3
9351200
35f6e81
de6a3c6
0546905
427fcbe
a85e167
fba5363
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little messy. In the case where we keep the left side of the badge but have no text it would be great to pass a tab character. However shields escapes label input so this doesn't work well. Instead we're looking for a strict match of the left txt inside html tags and replacing it with nothing afterwards. A placeholder
###
is used to create the svg space (so removing text doesn't remove the left side) in this case. Thoughts on improving this welcome.