Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __signature__ and set __wrapped__ attribute even on signature-changing decorators. #86

Merged
merged 12 commits into from
Sep 7, 2022
Merged

Use __signature__ and set __wrapped__ attribute even on signature-changing decorators. #86

merged 12 commits into from
Sep 7, 2022

Commits on Jun 25, 2022

  1. Add failing test reproducing smarie#85.

    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    20beb4a View commit details
    Browse the repository at this point in the history

  2. Fix test for smarie#85, and update test for smarie#66. 

    I am not sure the fix for smarie#66 was correct given that __wrapped__ is used by the
typing module in get_type_hints, and setting __signature__ seems to fix all other tests.
    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    f93d2b4 View commit details
    Browse the repository at this point in the history

  3. Update src/makefun/main.py 

    Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
    @lucaswiman @smarie
    lucaswiman and smarie committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    9041de2 View commit details
    Browse the repository at this point in the history

  4. Update tests/test_issues.py 

    Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
    @lucaswiman @smarie
    lucaswiman and smarie committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    7ef4191 View commit details
    Browse the repository at this point in the history

  5. Update tests/test_issues.py 

    Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
    @lucaswiman @smarie
    lucaswiman and smarie committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    95f7697 View commit details
    Browse the repository at this point in the history

  6. Update src/makefun/main.py

    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    5fc7b1c View commit details
    Browse the repository at this point in the history

  7. Fix tests. 

    1. Always setting __wrapped__ means we needed a slightly different assertion.
2. Support python <3.7 in the test suite.
    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    d9e9e3f View commit details
    Browse the repository at this point in the history

  8. Update version specifier to be more specific.

    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    9c54231 View commit details
    Browse the repository at this point in the history

  9. Get test suite passing on 2.7. 

    1. Rename issue_85_module so that it is not collected by pytest.
2. Use the signature polyfill rather than inspect.signature.
    @lucaswiman
    lucaswiman committed Jun 25, 2022
    Configuration menu
    Copy the full SHA
    4f5c5ca View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Update src/makefun/main.py

    @lucaswiman
    lucaswiman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a485b91 View commit details
    Browse the repository at this point in the history

  2. Update documentation to match new PEP 362 behavior.

    @lucaswiman
    lucaswiman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    ccc922a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Always evaluate the signature when __signature__ is specified as a st… 

    …ring.
    @lucaswiman
    lucaswiman committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0fe6a7e View commit details
    Browse the repository at this point in the history