By default, ignore archived projects. #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new CLI argument (--include-archived) and ENV VAR (MARGE_INCLUDE_ARCHIVED) which defaults to False. If True, Marge will process archived projects (which cannot have their MRs merged) as well as live projects (which can). The API for Project.fetch_all_mine() has changed to include an optional argument include_archived which matches the CLI arg. The current default behaviour is for Marge to process all projects, which wastes time and resources, linearly with the number of archived projects.
|
Thanks for your contribution, and sorry for the delay! My only review comment would be that option to inspect archived projects is not needed, if you remove it this is good to go in (i.e. archived projects should always be excluded, I don't see a case where overriding this would be useful). |
|
Many thanks, I've pushed a commit to make that change. Do you want me to squash? |
|
Yes, please! |
|
Once it's squashed, I'll merge. |
|
Great – thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
This is a first go at excluding archived projects; it likely needs better testing before it can be merged.
This PR adds a new CLI argument (
--include-archived) and ENV VAR (MARGE_INCLUDE_ARCHIVED) which defaults toFalse. IfTrue, Marge will process archived projects (which cannot have their MRs merged) as well as live projects (which can).The API for
Project.fetch_all_mine()has changed to include an optional argumentinclude_archivedwhich matches the CLI arg.The current default behaviour is for Marge to process all projects, which wastes time and resources, linearly with the number of archived projects.