Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new choice assigned_at to option merge_order #268

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

sg70
Copy link
Contributor

@sg70 sg70 commented Aug 19, 2020

Previously the option merge_order had two choices created_at and updated_at.
This is problematic in large projects as both options does not allow
the maintainer to control the order of merge requests.

This commit adds a new choice assigned_at to the option merge_order as
maintainers in large project often expect the order of the merge requests
related to order in which the merge requests did got assigned to the
marge-bot user.

Signed-off-by: Konrad Weihmann konrad.weihmann@mbition.io

@sg70 sg70 changed the title * Add new choice assigned_at to option merge_order Add new choice assigned_at to option merge_order Aug 19, 2020
@sg70 sg70 force-pushed the add-new-merge-order-assigned-at branch from 4f64ed9 to 86d6887 Compare October 16, 2020 18:49
@sg70 sg70 force-pushed the add-new-merge-order-assigned-at branch from 86d6887 to a9caeeb Compare November 1, 2020 19:14
@sg70 sg70 force-pushed the add-new-merge-order-assigned-at branch from a9caeeb to 0fc969a Compare November 15, 2020 15:55
@sg70
Copy link
Contributor Author

sg70 commented Nov 15, 2020

@tclh123 We use this custom version of marge-bot. It would be nice to have this merged into the project.

Previously the option merge_order had two choices created_at and updated_at.
This is problematic in large projects as both options does not allow
the maintainer to control the order of merge requests.

This commit adds a new choice assigned_at to option merge_order as
maintainers in large project often expect the order of the merge requests
related to order in which the merge requests did got assigned to the
marge-bot user.

Signed-off-by: Konrad Weihmann <konrad.weihmann@mbition.io>
@sg70 sg70 force-pushed the add-new-merge-order-assigned-at branch from 0fc969a to 939ddb3 Compare December 8, 2020 18:58
@tclh123 tclh123 merged commit c5f6300 into smarkets:master Dec 14, 2020
@tclh123
Copy link
Contributor

tclh123 commented Dec 14, 2020

@sg70 Thanks for your contribution!

@sg70 sg70 deleted the add-new-merge-order-assigned-at branch January 24, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants