Initialize ChartJS will all plugins unconditionally

This is mostly for convenience. I missed initializing the benchmark, but since we always do the same thing everywhere, I suspect I can just do it unconditionally. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr · Mar 23, 2024 · 003e04f · 003e04f
1 parent 1efe3f6
commit 003e04f
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/src/backend/compare/charts.ts b/src/backend/compare/charts.ts
@@ -25,9 +25,11 @@ const marginTopWithTitle = 34;
 const marginBottom = 28;
 const perEntryHeight = 34;
 
-export function initChartJS(): void {
+/** Register all standard plugins. This is for convenience. */
+function initChartJS(): void {
   Chart.register(...registerables);
 }
+initChartJS();
 
 function calculatePlotHeight(title: string | null, data: ChangeData): number {
   const result = marginBottom + data.labels.length * perEntryHeight;

diff --git a/src/index.ts b/src/index.ts
@@ -55,7 +55,6 @@ import {
 } from './backend/rebench/results.js';
 import { setTimeout } from 'node:timers/promises';
 import { reportConnectionRefused } from './shared/errors.js';
-import { initChartJS } from './backend/compare/charts.js';
 
 log.info('Starting ReBenchDB Version ' + rebenchVersion);
 
@@ -218,7 +217,6 @@ async function tryToConnect(n: number): Promise<boolean> {
   }
 
   await initPerfTracker(db);
-  initChartJS();
 
   log.info(`Starting server on http://localhost:${siteConfig.port}`);
   app.listen(siteConfig.port);

diff --git a/tests/backend/compare/charts.test.ts b/tests/backend/compare/charts.test.ts
@@ -9,7 +9,6 @@ import {
 import { robustPath } from '../../../src/backend/util.js';
 import {
   createCanvas,
-  initChartJS,
   renderInlinePlot,
   renderOverviewPlots
 } from '../../../src/backend/compare/charts.js';
@@ -26,7 +25,6 @@ import {
 } from '../../payload.js';
 
 initJestMatchers();
-initChartJS();
 
 const outputFolder = isRequestedToUpdateExpectedData()
   ? robustPath('../tests/data/expected-results/charts')

diff --git a/tests/backend/compare/compare-view.test.ts b/tests/backend/compare/compare-view.test.ts
@@ -30,10 +30,8 @@ import {
   loadCompareViewJsSomPayload,
   loadCompareViewTSomPayload
 } from '../../payload.js';
-import { initChartJS } from '../../../src/backend/compare/charts.js';
 
 initJestMatchers();
-initChartJS();
 
 const dataJsSOM = loadCompareViewJsSomPayload();
 const dataTruffleSOM = loadCompareViewTSomPayload();

diff --git a/tests/backend/compare/prep-data.test.ts b/tests/backend/compare/prep-data.test.ts
@@ -46,10 +46,8 @@ import {
   loadCompareViewJsSomPayload,
   loadCompareViewTSomPayload
 } from '../../payload.js';
-import { initChartJS } from '../../../src/backend/compare/charts.js';
 
 initJestMatchers();
-initChartJS();
 
 describe('compareStringOrNull()', () => {
   it('should compare null and null', () => {