Update to Chart.js 4 and use my own chartjs-node-canvas #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…JS 4 The vendored code is from https://github.com/smarr/ChartjsNodeCanvas/ Version: 644cdea2345b90f1f4a78d7344f62d90761cabf1 The changes are mostly whitespace and formatting, to easily fit into the local setup. - override sharp dependency in join-images Signed-off-by: Stefan Marr <git@stefan-marr.de>
…artJS 4 to have same appearance as before Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
bug
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This uses patch-package as a postinstall step to apply the fix. Signed-off-by: Stefan Marr <git@stefan-marr.de>
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to Chart.js 4 and uses a version of chartjs-node-canvas that does not rely on
freshRequireand various other bits of aggressive use of require (presumably to isolate plugins) and thereby avoids leaking memory on every chart.Thus, this PR addresses #188 as far as I can see. At least in manual testing, the memory profiles look clearly different between before and after.
Though, before this PR can be merged, sgratzl/chartjs-chart-boxplot#109 needs to be published, or I need to apply some local patches to allow chartjs-chart-boxplot to work on Node.js.
The PR updates also various other dependencies.