Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chartjs init for benchmark #191

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Commits on Mar 23, 2024

  1. Initialize ChartJS will all plugins unconditionally

    This is mostly for convenience. I missed initializing the benchmark, but since we always do the same thing everywhere, I suspect I can just do it unconditionally.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    003e04f View commit details
    Browse the repository at this point in the history
  2. Fix package-lock

    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    324f937 View commit details
    Browse the repository at this point in the history
  3. Document Dockerfile and caching logic

    I assume that package.json changes should invalidate the cache for the early copy
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    a01269b View commit details
    Browse the repository at this point in the history
  4. Explicitly copy the patches folder in Dockerfile

    This is needed, because we run the patching as part of the postinstall command, and thus, needed it before the full copy.
    
    Signed-off-by: Stefan Marr <git@stefan-marr.de>
    smarr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    55c5c5d View commit details
    Browse the repository at this point in the history