Fix #206: Add Show More Functionality and Default Filtering for Missing Data in Compare View #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarr bug fixed, and improved the show more feature into a collapsable section. |
staging unchanged files
TODO: fix formatting to avoid issues
Fixed formatting error caused by npm run lint
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
master
branch
3 times, most recently
from
e6327e9
to
924fcec
Compare
…anged Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This simplifies the implementation by using the nth-child pseudo class. This way, we do not need to loop over rows. It also removes unused CSS classes and changes the code style to fit more with the existing code. - CSS classes use “kebab-case”. - use JQuery to match existing code - remove the .showMore which was already unsued Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the usability of the compare view by introducing a "Show More" link for the "Changes in Benchmark Set" table. Key enhancements include:
.hiddenclass instyle.cssto manage the visibility of additional table rows.showAllResultsfunction to handle the display of all entries when the "Show More" link is clicked.