Fix isValue check for actor creation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
force-pushed
the
check-isvalue-for-actor-creation
branch
from
0b4d577
to
ac8753c
Compare
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Add proper exception and remove todo. Note, this change stops using the DSL for the IsValue node, because it was generating wrong code, and passing a `null` to isValue.execute*. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is to ensure the actor classes are values. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
check-isvalue-for-actor-creation
branch
from
ac8753c
to
c39b644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isValue check for actor creation was broken. Instead of checking on the actual value the actor is created from, it is checking on the module or nil.
So, there was a huge isolation issue in the actor implementation.
This fixes #101.