Make Kompos tests more robust, include more info in failures, and use ephemeral ports if necessary #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
bug
- add SOMns output to error - properly reject some of the promises - report error with stderr out when stream closes - added SOMns process kill - add shutdown hook to close sockets - wait until process exit with failing test Signed-off-by: Stefan Marr <git@stefan-marr.de>
Kompos tests fail on travis some times with an address already bound error. To avoid it, try to use standard port, and if already in use, use an ephemeral port instead. The web socket ports can be communicated via JSON and easily queried by the frontend. The HTTP port needs to be parsed out of the STDOUT. - update SOMns-deps to have latest WebSocket lib version - in tests, parse stdout for ports - remove duplicate code of old BinaryWebSocketHandler Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kompos tests are sometimes failing on Travis because the old server is still running/shutting down.
So, there is some race.
One problem might be that there is a reuse timeout.
If there is no other race/promise not handled correctly, we might need to look into using:
setReuseAddress(true)on the socket.Instead of using
setReuseAddress(true), I am switching to using ephemeral ports, i.e., random ports when the normal ones are in use.The port numbers are reported in standard out and are parsed out by the tests.
In the frontend code, I am using a JSON request to retrieve them via HTTP.