Adopt Newspeak Setter Sends instead of Assignment Syntax #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #7.
To be Newspeak spec compliant, we need to move from the classic
var := 42
assignment syntax to the Newspeak setter send syntax where we gotvar:: 42
instead.The main motivation for the change is compliance and the ability to load Newspeak code at some point directly.
The changes in the parser and lexer remove the previous use of an
Assign
symbol, and instead, following the Newspeak spec, lex aSetterKeyword
. This makes sure that there can't be whitespace between the two colons.SOMns Code Transformation
To adapt existing code, I used the following:
Note that previously, multiple white spaces where allowed before the assignment
:=
.To fix up parsing issues, and preserve alignment, I used this (actually I did search replace of the equivalent in my editor, so this is untested):