Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew Safepoint assumption only when invalid #291

Merged
merged 4 commits into from Feb 9, 2019

Conversation

1 participant
@smarr
Copy link
Owner

commented Feb 8, 2019

The assumption should not be replaced without invalidating it, or to put it differently:
If it is replaced before invalidation, the notice of invalidation may be lost. Thus, code depending on it is never invalidated.

  • also added two more tests

smarr added some commits Feb 8, 2019

Added safepoint test with many registrations
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Only renew Safepoint assumption when it is invalidated
If we do replace a valid assumption, it may never be invalidated, because there’s no reference to it any more.

Signed-off-by: Stefan Marr <git@stefan-marr.de>
Change ParallelHelper to provide thread id
Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr added the enhancement label Feb 8, 2019

@smarr smarr added this to the v0.7.0 milestone Feb 8, 2019

@smarr smarr added this to Open Issues in Completeness via automation Feb 8, 2019

Added more safepoint tests
Signed-off-by: Stefan Marr <git@stefan-marr.de>

@smarr smarr force-pushed the safepoint-fix branch from c06cb21 to d6cf980 Feb 8, 2019

@smarr smarr merged commit 62f06cd into dev Feb 9, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/gitlab/git.cs.kent.ac.uk Pipeline passed on GitLab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.582%
Details

Completeness automation moved this from Open Issues to Completed Feb 9, 2019

@smarr smarr deleted the safepoint-fix branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.