New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for actor-language features to Dynamic Metrics tool #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
Improves the implementation with something noteworthy
label
Apr 13, 2020
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This format is much easier to read and map to a file. Signed-off-by: Stefan Marr <git@stefan-marr.de>
No specific actor support yet, but at least support promises, far references, and resolver objects. Also add support for a few other things. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
The maps where unused and were missed in an old refactoring. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- and provide necessary support for CreatePromisePairPrim Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is just the primitive, not yet on the source level, which might need a primitive wrapping this to pass on the breakpoint parameters correctly. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
actor-dym
branch
3 times, most recently
from
April 16, 2020 00:07
5d71fb9
to
3492657
Compare
- Num.Actors - Num.Turns - Num.Promises - Num.Resolvers - Num.Promises.Avoided - Num.Registered.WhenResolved - Num.Registered.OnError - Num.Scheduled.WhenResolved - Num.Scheduled.OnError Signed-off-by: Stefan Marr <git@stefan-marr.de>
…>#resolve: This node itself does not need to be instrumented, because its child node will be instrumented as in all other locations where it is used. Signed-off-by: Stefan Marr <git@stefan-marr.de>
…s [WIP] This replaces the rather elaborate and brittle way we used instrumentation to count the activation of specific call targets by having a wrapping node that counts activations and can be collected from the message send node. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…l nodes with counting call nodes [WIP] Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Hasn’t been used in ages Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
…lved Signed-off-by: Stefan Marr <git@stefan-marr.de>
- rename resolve to promiseResolve Signed-off-by: Stefan Marr <git@stefan-marr.de>
Perhaps another time, not urgent for the moment. Signed-off-by: Stefan Marr <git@stefan-marr.de>
…strap popovers Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is a correctness precaution. All subsequent register/unregister operations following an initial unregister/register need to be in a finally clause if the operations in-between could cause any kind of exception, which most can. For consistency, it should be used really everywhere. There are only two points where it might be acceptable, but should be still fixed: init of object system, and in the executeApplication method. Signed-off-by: Stefan Marr <git@stefan-marr.de>
…no longer skip any frames Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to improve the Dynamic Metric tool to be able to measure all actor-related language features.
Specifically, this means to measure:
For later:
In addition to the main changes, the PR does some maintenance:
This is not all that could be done. More work is tracked with #349.