Turn the KomposDemo into benchmark, and optimize ValueCheckNode #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems as if it is currently broken. There does seem to be a race in the prefix sum calculation. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This node is used in the constructor of Value objects, which are not allowed to have any members that are mutable. The now optimized node takes the layout of an object and gets all the slot accessors that can potentially access mutable objects, i.e., the slots containing non-primitives. It constructs a tester object, which will then test these fields. The fallback case, i.e., when we see too many layouts, is the old code, that simply goes over all slots and checks whether it contains a value. Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
the
enhancement
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working version of the KomposDemo as an actor benchmark.
To optimize compilation, the PR also improves the ValueCheckNode.
The initial version simply iterated over all object fields and checked whether each of them contains null or a value.
The optimized version creates a tester that has the accessors for the object fields, and uses them to check with a dedicated IsValue node whether the relevant fields contain values.
@sophie-kaleba this is perhaps an interesting optimization for you.
@daumayr I hope this is what we can use for the revision. I was thinking, maybe we want to add a use of STM to it though.