Fix performance issue in ArrayLiteralNode and optimize access of context objects #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to deoptimize when we actually got something other than the expected type. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is mostly to make the output of --perf-warnings more concise Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialization logic was included into the compilation, which causes code bloat.
The context objects could be well optimized in some cases where outer context access would cause a virtual method call, because the type was not known at compilation.
@sophie-kaleba: the two optimizations might be interesting for you, just as other examples.
This PR also remove the "Method"/"Primitive" strings from the names of the corresponding objects. Should be obvious enough in compilation logs.