Refactor Actor-Debugging-related Code to make concepts more explicit and use GSON for JSON communication #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
smarr
force-pushed
the
refactoring/mli
branch
4 times, most recently
from
33e5de7
to
ad12f96
Compare
We need that instead of a source section to identify not yet loaded source locations. Make charIndex transient. We rely on line/column to identify location. Signed-off-by: Stefan Marr <git@stefan-marr.de>
- manage assumption about enabling part of all breakpoints - introduce sender adn receiver breakpoint classes - use FullSourceCoordinate Signed-off-by: Stefan Marr <git@stefan-marr.de>
We need to think about this carefully and find good names still. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is currently targetted mostly at the existing JSON backend, and might change. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- move breakpoints into separate class files Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
- don’t use cross-program ids - don’t use char index, make due with line/column Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is not yet supported by the front-end, but is necessary, since I move the updating of source section info out of the suspended event message Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
This is not used any longer. Sources are identified by URI. Source Sections are identified by a (line, column, length) tuple. Signed-off-by: Stefan Marr <git@stefan-marr.de>
It is not longer maintained as a stand-alone tool. Was never used as such. So, if it is needed, we’ll find this commit in the archives. - VMTests, set VmSettings.INSTRUMENTATION before class, hope this avoids issues. Signed-off-by: Stefan Marr <git@stefan-marr.de> Set VmSetting before class Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this work is to more clearly work out a meta-level interface for debugging actor languages.
So, the code should represent concepts explicitly.
Then, a front-end for instance connected via JSON should just use that API.
The API itself might also be exposed to the language for reflective use.
This is related to #35.
The changes also use GSON instead of custom JSON serialization.
A brief overview: