Fix lookup issues caused by incorrect outer object reads #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add specializations for the basic types - remove crude hack to just return kernel - handle lookup for SFarReference depending on mixinId and context level - cache far ref mixin id - add a little documentation Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
fix/outer-object-read
branch
from
097b40a
to
b9ff5fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is currently blocked on #34.
Looks like it was hiding a place in the tests that becomes a megamorphic super send now.