Fix usage of StatementTag to fit with Truffle's expectations #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of StatementTag for the debugger requires that only classic statements are tagged. Otherwise, the stepping semantics are incorrect. Thus, expressions, nested in statements should not be tagged as statements. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Necessary after changing the tagging of statements. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, all expressions were tagged as statements, while they should not be tagged as such. The tagging causes problems with stepping strategies.
Statements are meant to be only the directly contained elements of method bodies or blocks, etc. So, essentially all sequences of expressions from the Newspeak grammar. Especially nested expressions are not tagged as statements anymore.
This required a few small extensions in Truffle to be able to have breakpoints on things that are not statements.
The main goal is to make stepping in the debugger more 'usual'. Especially necessary for the VS code debugger.