Move specialization of nodes to parse time #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarr
added
the
enhancement
smarr
force-pushed
the
in-parser-specialization
branch
2 times, most recently
from
cabe135
to
ec23b6c
Compare
When creating the AST nodes, we use the symbol and the child nodes to determine whether we can create already a specialized node. This avoids creating uninitialized message send nodes, which do the specialization at run time. A primitive defines with the `inParser` property whether it supports this. - make sure the arguments are marked for eager primitives - make inParser flag true by default Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
in-parser-specialization
branch
from
83df3b0
to
e7634fd
Compare
…isspeculation Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
in-parser-specialization
branch
from
e7634fd
to
dda69ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to do the specialization of
+and similar nodes already at parse time.This should avoid the need for an extra specialization at run time, and minimally improve startup.
Furthermore, it means we already have a chance after AST construction to know likely tags in the AST. This is helping with tooling support.
This is a fix for #75.