Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add occupancy information #12

Conversation

danielvillalbamota
Copy link
Contributor

Add some occupancy attributes for some systems that do not manage available spots but occupied ones.

  • occupiedSpotNumber : Number of spots occupied.
  • occupancyModified : Timestamp when the occupiedSpotNumber was updated. The format follows the ISO8601.
  • percentageOccupancy : Percentage of occupied spots over the total.

@albertoabellagarcia
Copy link
Contributor

As stated in the guidelines all the values which are relative it should be expressed in a value between 0 and 1.
The rest of the changes looks nice. Fix it to be accepted.

@danielvillalbamota
Copy link
Contributor Author

Ok, is there a naming convention for this kind of relatives values? I have seen some attributes with the suffix "Level" (e.g. occupancyLevel), but I would like to find the proper one.

@albertoabellagarcia
Copy link
Contributor

We have neither a recommendation nor an obligation regarding this. Maybe we should.
What it is true is that you can use a plain name (without a level suffix) for magnitudes which are relative.
so my recommendation would be if this is a real magnitude use the plain name. It is not necessary to identify that the magnitude is a percentage in the property name.

@danielvillalbamota
Copy link
Contributor Author

Ok, then I will leave it simple. I am going to propose "occupancy" as the relative value of occupied spots out of the total spots.

@danielvillalbamota
Copy link
Contributor Author

I want to include two more attribute related to the number of vehicle that enter and leave the parking (vehicleEntranceCount and vehicleExitCount), Should I do it in this PR or in a new one?

@albertoabellagarcia albertoabellagarcia merged commit cf1395d into smart-data-models:master Nov 3, 2020
@albertoabellagarcia
Copy link
Contributor

mostly right. There is a minor issue on the schema, I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants