Misc fixes in Pump and Tank data models #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove attributes from mandatory list that do not have do be specified or cannot be specified simultaneously. Remove `head` attribute, as if a `head` is specified in the EPANET network model this is a head curve. Rename the `pumpCurve` attribute as `headCurve`. Remove `headCurve` attribute from example, as either `headCurve` or `power` is required, not both.
Change tank `volumeCurve` attrubute from a property to a relationship (to a curve).
Update tanks and pumps
Add `valveCurve` attribute to valves. Required only when `valveType` is `GPV`.
Change pump `efficCurve` attribute to a relationship
`timeStep` is required to define the intervals at which the `multipliers` are to be applied.
Remove attributes from mandatory list that do not have do be specified or cannot be specified simultaneously. Remove `head` attribute, as if a `head` is specified in the EPANET network model this is a head curve. Rename the `pumpCurve` attribute as `headCurve`. Remove `headCurve` attribute from example, as either `headCurve` or `power` is required, not both.
Change tank `volumeCurve` attrubute from a property to a relationship (to a curve).
Add `valveCurve` attribute and make `efficCurve` a relationship
fix $id, fix wrong links, add figure sources
|
Nice, there are a couple of questions that we will have to adapt later, any how great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.