Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial gamma correction implementation #3

Merged
merged 2 commits into from
Jan 29, 2019
Merged

initial gamma correction implementation #3

merged 2 commits into from
Jan 29, 2019

Conversation

sajattack
Copy link
Collaborator

@sajattack sajattack commented Jan 28, 2019

Using a lookup table, I think the on-the-fly method would be too slow.
Here's a shitty gif showing orange (looks yellow) versus gamma-corrected orange (looks a bit too red in this gif but better irl):
gif
Do you want me to add this demo to smart-leds-samples?

@david-sawatzke
Copy link
Contributor

Adding an example is a good idea. Not too happy about the lookup table, but you're probably right about it being too slow. A note about this fixing the colors & that gamma correction should come after the brightness adjustment would be great.

@sajattack
Copy link
Collaborator Author

I did the gamma correction and then the brightness, that's wrong?

@david-sawatzke
Copy link
Contributor

Sorry that wasn't very clear. I just want to add a note about that in the doc comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants