Use relative paths for access to modules (avoid sys.path fiddling) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
force-pushed
the
mikix/drop-path-edits
branch
4 times, most recently
from
b72c65e
to
c680f40
Compare
mikix
commented
Jul 15, 2024
There was a problem hiding this comment.
This test just written to bump up our code coverage from 35% to 45%
These are unnecessary nowadays and dropping them will reduce complexity and improve coverage reporting.
mikix
force-pushed
the
mikix/drop-path-edits
branch
from
c680f40
to
54e6313
Compare
mikix
commented
Jul 15, 2024
Comment on lines
-45
to
+47
| if: github.ref != 'refs/heads/main' | ||
| # Disable coverage checking from forks until there is a secure fix for: | ||
| # https://github.com/orgoro/coverage/issues/259 | ||
| if: github.ref != 'refs/heads/main' && ${{ ! github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
This is unrelated, but I noticed this problem when trying to to land #109 -- coverage fails on fork branches 😦
There was a problem hiding this comment.
oh fascinating - i guess that should probably be something we do elsewhere.
dogversioning
approved these changes
Jul 15, 2024
Comment on lines
-45
to
+47
| if: github.ref != 'refs/heads/main' | ||
| # Disable coverage checking from forks until there is a secure fix for: | ||
| # https://github.com/orgoro/coverage/issues/259 | ||
| if: github.ref != 'refs/heads/main' && ${{ ! github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
oh fascinating - i guess that should probably be something we do elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick from #134 (which has other unrelated patches in it, which is why I'm making a separate, focused PR) and a commit of my own invention to drop an old python2-workaround from the templates (which gets us back in sync with how fhir-parser does it in the sample templates).
This drops python2 support without bumping the major version. I think though, that fhirclient's versioning is a little unique. Maybe it's worth talking about. Here's how I was thinking about it:
pip installrun that is stuck on old runtimes won't download your new package)If we don't like the above approach, I could buy disconnecting the major version from the FHIR version and just making it clear what the support matrix is (like our README kind of already does).
Fixes #110