-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client_uri should be a property on SIOP Request, not .registration #24
Comments
Having trouble accessing the Openid Spec for Dynamic client registration, but the OAuth RFC I think it's based on has "client_uri" in the metadata. |
Yes, just like e.g. |
Fix #24 by moving client_uri to a top-level request param
Uh, now that I got around to implementing this, I'm not so sure it's correct :-) I'll follow up. |
@p2-apple Those two fields are specific to a given request, and not generically to a given client. Note, |
Agreed @madaster97. I'm double checking with the person who initially raised this issue to make sure I'm not missing anything, but my reading matches yours. |
I was comparing it with the OAuth2 metadata keys, but right, client_uri has a different meaning there. From an OID perspective it actually seems to make sense to keep it in registration, thanks for the close reading @madaster97 ! |
Thanks -- I've reverted the fix and will close this out. |
client_uri
should be not inregistration
but an optional parameter directly in the request?client_uri
should move up to be a siblingThe text was updated successfully, but these errors were encountered: