Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance extended community support #54

Merged
merged 22 commits into from
Oct 25, 2017
Merged

Conversation

meidli
Copy link
Contributor

@meidli meidli commented Oct 25, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 60.057% when pulling a9e30bd on meidli:master into 6034bb7 on smartbgp:master.

Copy link
Member

@xiaopeng163 xiaopeng163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my code comments

@@ -25,6 +25,7 @@ import urllib2
import json
import time

from __future__ import print_function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure future import at the top of imports statements

yabgp/api/v1.py Outdated
})
print 'ext'
print ext_community
attr[16] = ext_community
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print is a function after future import

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 60.089% when pulling 13d1af9 on meidli:master into 6034bb7 on smartbgp:master.

@xiaopeng163 xiaopeng163 merged commit 58b6214 into smartbgp:master Oct 25, 2017
@xiaopeng163
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants