Skip to content

Commit

Permalink
Merge pull request #36 from smartbooster/test_job_except_main
Browse files Browse the repository at this point in the history
Add `main` except branch for test job + Remove deploy.mk GIT_BRANCH unused variable
  • Loading branch information
mathieu-ducrot committed Feb 6, 2024
2 parents 7f770a5 + 53f0266 commit 20a8680
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ test:
- docker
except:
- master
- main
services:
- mysql:8.0
variables:
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
CHANGELOG for 1.x
===================

## v1.0.5 - (2024-02-06)
### Changed
- Also add the `main` branch to the except branch for the test job

### Removed
- `deploy.mk` removed the GIT_BRANCH variable as it is not used anymore on deploy-revision

## v1.0.4 - (2024-01-18)
### Changed
- Refactor `bundle.mk` to a more targetted use case of our bundles.
Expand Down
6 changes: 0 additions & 6 deletions make/deploy.mk
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
##
## Deploy
## ----------
ifeq ($(shell git name-rev --name-only HEAD),remotes/origin/HEAD)
GIT_BRANCH=master
else
GIT_BRANCH=$(shell git name-rev --name-only HEAD)
endif

.PHONY: deploy-revision
deploy-revision: ## Create deploy revision file
touch public/revision.txt
Expand Down

0 comments on commit 20a8680

Please sign in to comment.