New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF3.4 compatibility #113
SF3.4 compatibility #113
Conversation
04ca227
to
0e3df58
Compare
…rride the built in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreskrey , there are few comments that should be addressed before we can merge this changes. We should also make sure that these changes works in Symfony 2.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Andres, there were some comments added in framework that I didn't publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are ready to be merged, good job!
No description provided.