Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes broken e2e test #50

Merged
merged 2 commits into from Apr 19, 2019
Merged

fix: Fixes broken e2e test #50

merged 2 commits into from Apr 19, 2019

Conversation

morgannewman
Copy link
Contributor

@morgannewman morgannewman commented Apr 19, 2019

Context: I changed the ID of oem-auth's login button from approval-button to sign-in-button.

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage     60.67%   60.67%           
  Complexity       61       61           
=========================================
  Files            17       17           
  Lines           417      417           
  Branches         18       18           
=========================================
  Hits            253      253           
  Misses          155      155           
  Partials          9        9
Flag Coverage Δ Complexity Δ
#integration 48.44% <ø> (ø) 51 <ø> (ø) ⬇️
#test 16.78% <ø> (ø) 15 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae47dd...18dcaf7. Read the comment docs.

Copy link
Contributor

@allisonc07 allisonc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! lgtm

@morgannewman morgannewman merged commit 9692671 into master Apr 19, 2019
@morgannewman morgannewman deleted the fixes-broken-e2e-test branch April 19, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants