commit plugin ocr3 - Code cleanup and minor fixes #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dimkouv
commented
May 16, 2024
dimkouv
commented
- Convert method to function
- Rename var to not shadow function
- Minor refactoring
- Include token prices in outcome
- ...
|
I see you updated files related to |
makramkd
approved these changes
May 16, 2024
| @@ -186,6 +186,11 @@ func (p *Plugin) ObservationQuorum(_ ocr3types.OutcomeContext, _ types.Query) (o | |||
| // - Merkle Roots: One merkle tree root per source chain. The leaves of the tree are the IDs of the observed messages. | |||
| // The merkle root data type contains information about the chain and the sequence numbers range. | |||
| func (p *Plugin) Outcome(_ ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation) (ocr3types.Outcome, error) { | |||
| fChainDest, ok := p.cfg.FChain[p.cfg.DestChain] | |||
There was a problem hiding this comment.
Side note but this is something good to check when creating the plugin. Can put a TODO/ticket for the future
|
|
||
| /* | ||
| Once token/gas prices are implemented, we would want to probably check if outc.MerkleRoots is empty or not | ||
| todo: Once token/gas prices are implemented, we would want to probably check if outc.MerkleRoots is empty or not |
There was a problem hiding this comment.
Good to create a ticket for this as well, I think the timer/timestamp for this would have to be in the outcome right, so that the committee can agree on it?
There was a problem hiding this comment.
Compare prevOutcome.Timestamp to current timestamp, if > 30 min or whatever (configurable) then include prices in the outcome?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.