Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiOnRamp token transfer fee config #928

Merged
merged 17 commits into from
Jun 3, 2024

Conversation

RayXpub
Copy link
Collaborator

@RayXpub RayXpub commented May 27, 2024

Motivation

Implements per destination chain token transfer fee configs in the EVM2EVMMultiOnRamp, which allows the OnRamp to support more than one destination chain configuration.

Solution

  • TokenTransferFeeConfig is now per destination chain per token
  • added a TokenTransferFeeConfigArgs containing:
    • A destChainSelector
    • A TokenTransferFeeConfigSingleTokenArgs nested struct with token + TokenTransferFeeConfig

Out of scope:

  • Full contract coverage

@RayXpub RayXpub changed the base branch from ccip-develop to feat/multi-onramp-fee-token-config May 27, 2024 17:30
Copy link
Contributor

github-actions bot commented May 27, 2024

LCOV of commit 4b6d442 during Solidity Foundry #4879

Summary coverage rate:
  lines......: 98.7% (1485 of 1505 lines)
  functions..: 96.5% (303 of 314 functions)
  branches...: 92.7% (643 of 694 branches)

Files changed coverage rate: n/a

@RayXpub RayXpub changed the title feat: implement multi onramp fee token configs MultiOnRamp token transfer fee config May 28, 2024
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@RayXpub RayXpub marked this pull request as ready for review May 28, 2024 06:50
@RayXpub RayXpub requested review from makramkd and a team as code owners May 28, 2024 06:50
Base automatically changed from feat/multi-onramp-fee-token-config to ccip-develop May 30, 2024 10:33
@RayXpub RayXpub force-pushed the feat/multi-onramp-token-transfer-fee-config branch from 36e4e85 to 3d9fd84 Compare May 30, 2024 12:56
@RayXpub RayXpub force-pushed the feat/multi-onramp-token-transfer-fee-config branch from 3d9fd84 to 79d3756 Compare May 30, 2024 13:25
@RayXpub RayXpub merged commit 829fe43 into ccip-develop Jun 3, 2024
75 of 77 checks passed
@RayXpub RayXpub deleted the feat/multi-onramp-token-transfer-fee-config branch June 3, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants