-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add context #304
base: main
Are you sure you want to change the base?
add context #304
Conversation
1dd41d1
to
88cfd02
Compare
The linter is very confused. I tried updating to a new version of golangci-lint and using the regular one instead of our custom action, but it is still failing the same way 🤔 |
88cfd02
to
95c1ac3
Compare
36b1bd8
to
88ec42a
Compare
f85e998
to
ea2dc06
Compare
67354bd
to
57aca69
Compare
@@ -28,11 +24,12 @@ require ( | |||
github.com/beorn7/perks v1.0.1 // indirect | |||
github.com/bits-and-blooms/bitset v1.10.0 // indirect | |||
github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect | |||
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.3 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including this line prevents the ambiguous package problem that the btcd replace was addressing.
@@ -2,24 +2,20 @@ module github.com/smartcontractkit/chainlink-automation | |||
|
|||
go 1.21 | |||
|
|||
replace ( | |||
github.com/btcsuite/btcd => github.com/btcsuite/btcd v0.23.3 | |||
golang/github.com/gogo/protobuf => golang/github.com/gogo/protobuf v1.3.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protobuf module was unused.
golang.org/x/tools v0.15.0 // indirect | ||
google.golang.org/protobuf v1.31.0 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
rsc.io/tmplfunc v0.0.3 // indirect | ||
) | ||
|
||
exclude golang/github.com/influxdata/influxdb v1.8.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused
eb3df23
to
2240834
Compare
2240834
to
5583a02
Compare
5583a02
to
1ba5b9d
Compare
https://smartcontract-it.atlassian.net/browse/BCF-2887
Requires:
Supports: