migrate common utils from core/internal/testutils/testutils.go #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Nov 3, 2023
jmank88
reviewed
Nov 3, 2023
|
|
||
| // TestInterval is just a sensible poll interval that gives fast tests without | ||
| // risk of spamming | ||
| const TestInterval = 100 * time.Millisecond |
There was a problem hiding this comment.
Does this one need to be exported?
There was a problem hiding this comment.
Yes, there are 50 cases in core where testutils.TestInterval is used
Co-authored-by: Jordan Krage <jmank88@gmail.com>
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Nov 3, 2023
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.