Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/logger: add basic zap test and prod logger #49

Merged
merged 2 commits into from
May 16, 2022
Merged

pkg/logger: add basic zap test and prod logger #49

merged 2 commits into from
May 16, 2022

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented May 13, 2022 •
edited

This was referenced May 13, 2022
Merged
Merged
@jmank88 jmank88 marked this pull request as ready for review May 14, 2022 10:41
topliceanu
topliceanu previously approved these changes May 14, 2022
View reviewed changes
topliceanu
topliceanu reviewed May 14, 2022
View reviewed changes
pkg/logger/logger.go Outdated Show resolved Hide resolved
@jmank88 jmank88 requested a review from topliceanu May 14, 2022 12:59
jmank88
jmank88 commented May 14, 2022
View reviewed changes
pkg/logger/logger.go Outdated Show resolved Hide resolved
jmank88
jmank88 commented May 14, 2022
View reviewed changes
pkg/logger/logger.go Outdated Show resolved Hide resolved
topliceanu
topliceanu previously approved these changes May 15, 2022
View reviewed changes
pkg/logger/logger.go Outdated Show resolved Hide resolved
@topliceanu
Copy link
Collaborator

core/logger is the only dependency chainlink-relay/pkg/monitoring has on core. I wanted to remove it and replace it with zap directly for months now! I appreciate you adding this!

@jmank88 jmank88 requested a review from topliceanu May 16, 2022 11:27
topliceanu
topliceanu approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@topliceanu topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmank88 jmank88 merged commit 84fcd5e into main May 16, 2022
@jmank88 jmank88 deleted the logger branch May 16, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topliceanu topliceanu topliceanu approved these changes

@aalu1418 aalu1418 Awaiting requested review from aalu1418

@krebernisak krebernisak Awaiting requested review from krebernisak krebernisak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmank88 @topliceanu