-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Confirmations to Confidence #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
requested review from
ilija42
and removed request for
krebernisak and
jmank88
April 25, 2024 23:37
EasterTheBunny
temporarily deployed
to
integration
April 25, 2024 23:37
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
April 25, 2024 23:37
— with
GitHub Actions
Failure
EasterTheBunny
had a problem deploying
to
integration
April 25, 2024 23:37
— with
GitHub Actions
Failure
ilija42
requested changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR diff got broken when Querying PR was merged
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 7, 2024 17:57
348efb0
to
0d46dce
Compare
EasterTheBunny
had a problem deploying
to
integration
May 7, 2024 17:58
— with
GitHub Actions
Failure
EasterTheBunny
had a problem deploying
to
integration
May 7, 2024 17:58
— with
GitHub Actions
Failure
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 8, 2024 14:54
0d46dce
to
e8e6027
Compare
EasterTheBunny
had a problem deploying
to
integration
May 8, 2024 14:54
— with
GitHub Actions
Failure
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 14, 2024 14:54
e8e6027
to
b176d9e
Compare
EasterTheBunny
temporarily deployed
to
integration
May 14, 2024 14:54
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 14, 2024 14:54
— with
GitHub Actions
Failure
EasterTheBunny
temporarily deployed
to
integration
May 14, 2024 14:54
— with
GitHub Actions
Inactive
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 16, 2024 23:20
b176d9e
to
abc3921
Compare
EasterTheBunny
temporarily deployed
to
integration
May 16, 2024 23:20
— with
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
May 16, 2024 23:20
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 16, 2024 23:20
— with
GitHub Actions
Failure
EasterTheBunny
had a problem deploying
to
integration
May 22, 2024 16:44
— with
GitHub Actions
Error
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 22, 2024 16:44
6c9f1df
to
9fcbbd8
Compare
EasterTheBunny
temporarily deployed
to
integration
May 22, 2024 16:45
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 22, 2024 16:45
— with
GitHub Actions
Failure
EasterTheBunny
temporarily deployed
to
integration
May 22, 2024 16:45
— with
GitHub Actions
Inactive
ilija42
reviewed
May 23, 2024
ilija42
previously approved these changes
May 24, 2024
ilija42
reviewed
May 24, 2024
EasterTheBunny
had a problem deploying
to
integration
May 24, 2024 16:52
— with
GitHub Actions
Error
EasterTheBunny
had a problem deploying
to
integration
May 24, 2024 16:52
— with
GitHub Actions
Error
EasterTheBunny
had a problem deploying
to
integration
May 24, 2024 16:52
— with
GitHub Actions
Error
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 24, 2024 16:54
766bc05
to
14b0495
Compare
EasterTheBunny
temporarily deployed
to
integration
May 24, 2024 16:54
— with
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
May 24, 2024 16:54
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 24, 2024 16:54
— with
GitHub Actions
Failure
EasterTheBunny
temporarily deployed
to
integration
May 24, 2024 17:09
— with
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
May 24, 2024 17:09
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 24, 2024 17:09
— with
GitHub Actions
Failure
`Confidence` is a different approach to mapping a chain agnostic concept of confidence that an event or transaction can or should be acted on. `Confidence` is intended to map to defined levels of confirmations on EVM chains and other states on other chains. Only two levels of `Confidence` exist by default to define the boundaries: `Highest` and `Lowest`. This creates an inclusive range for all chain configurable `Confidence` levels and can be treated as % confidence that an event or transaction can or should be acted on.
EasterTheBunny
force-pushed
the
BCF-3156-confidence-level
branch
from
May 28, 2024 16:26
35a0390
to
288cce3
Compare
EasterTheBunny
temporarily deployed
to
integration
May 28, 2024 16:26
— with
GitHub Actions
Inactive
EasterTheBunny
temporarily deployed
to
integration
May 28, 2024 16:26
— with
GitHub Actions
Inactive
EasterTheBunny
had a problem deploying
to
integration
May 28, 2024 16:26
— with
GitHub Actions
Failure
ilija42
approved these changes
May 28, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
May 30, 2024
* Change Confirmations to Confidence `Confidence` is a different approach to mapping a chain agnostic concept of confidence that an event or transaction can or should be acted on. `Confidence` is intended to map to defined levels of confirmations on EVM chains and other states on other chains. Only two levels of `Confidence` exist by default to define the boundaries: `Finalized` and `Unconfirmed`. This creates an inclusive range for all chain configurable `Confidence` levels and can be treated as % confidence that an event or transaction can or should be acted on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confidence
is a different approach to mapping a chain agnostic concept of confidence that an event or transaction can or should be acted on.Confidence
is intended to map to defined levels of confirmations on EVM chains and other states on other chains.Only two levels of
Confidence
exist by default to define the boundaries:Highest
andLowest
. This creates an inclusive range for all chain configurableConfidence
levels and can be treated as % confidence that an event or transaction can or should be acted on.