Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Confirmations to Confidence #494

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

EasterTheBunny
Copy link
Collaborator

Confidence is a different approach to mapping a chain agnostic concept of confidence that an event or transaction can or should be acted on. Confidence is intended to map to defined levels of confirmations on EVM chains and other states on other chains.

Only two levels of Confidence exist by default to define the boundaries: Highest and Lowest. This creates an inclusive range for all chain configurable Confidence levels and can be treated as % confidence that an event or transaction can or should be acted on.

@EasterTheBunny EasterTheBunny requested review from ilija42 and removed request for krebernisak and jmank88 April 25, 2024 23:37
Base automatically changed from chain-reader-event-querying2 to main May 6, 2024 14:48
Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR diff got broken when Querying PR was merged

ilija42
ilija42 previously approved these changes May 24, 2024
pkg/types/query/query.go Outdated Show resolved Hide resolved
`Confidence` is a different approach to mapping a chain agnostic concept of confidence that
an event or transaction can or should be acted on. `Confidence` is intended to map to defined
levels of confirmations on EVM chains and other states on other chains.

Only two levels of `Confidence` exist by default to define the boundaries: `Highest` and
`Lowest`. This creates an inclusive range for all chain configurable `Confidence` levels and
can be treated as % confidence that an event or transaction can or should be acted on.
@EasterTheBunny EasterTheBunny merged commit 19b9064 into main May 28, 2024
8 of 9 checks passed
@EasterTheBunny EasterTheBunny deleted the BCF-3156-confidence-level branch May 28, 2024 16:57
cedric-cordenier pushed a commit that referenced this pull request May 30, 2024
* Change Confirmations to Confidence

`Confidence` is a different approach to mapping a chain agnostic concept of confidence that
an event or transaction can or should be acted on. `Confidence` is intended to map to defined
levels of confirmations on EVM chains and other states on other chains.

Only two levels of `Confidence` exist by default to define the boundaries: `Finalized` and
`Unconfirmed`. This creates an inclusive range for all chain configurable `Confidence` levels and
can be treated as % confidence that an event or transaction can or should be acted on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants