ks-146 standard capability framework #514
Conversation
ettec
force-pushed
the
ks-146/standard-capability
branch
from
c29ac37
to
663356f
Compare
ettec
force-pushed
the
ks-146/standard-capability
branch
from
663356f
to
4759b73
Compare
pkg/loop/internal/core/services/capability/standard_capability.go
Outdated
Show resolved
Hide resolved
pkg/loop/internal/core/services/capability/test/standard_capability.go
Outdated
Show resolved
Hide resolved
| } | ||
| c.resources = append(c.resources, errorLogRes) | ||
|
|
||
| pipelineRunnerID, pipelineRunnerRes, err := c.ServeNew("PipelineRunner", func(s *grpc.Server) { |
There was a problem hiding this comment.
Why do we need a pipeline runner?
There was a problem hiding this comment.
My understanding is that the standard capability is analogous to a generic plugin, and thus should have the same resources available to it, one of those being pipeline runner. IIRC I did raise this specific question regarding pipeline runner with Cedric to check (same as for keyvalue store). As I understand it the idea is that we give the capability/plugin writers as much functionality as possible to avoid them having to write custom implementations that would have to access core code directly.
There was a problem hiding this comment.
Do we plan to use this for any existing capabilities? If not, is it worth considering keeping the API surface small if there is a way to extend the API in a non-breaking way later?
There was a problem hiding this comment.
Do we plan to use this for any existing capabilities? If not, is it worth considering keeping the API surface small if there is a way to extend the API in a non-breaking way later?
Nvm, we actually need it for the Consensus capability.
| } | ||
| c.resources = append(c.resources, telemetryRes) | ||
|
|
||
| keyValueStoreID, keyValueStoreRes, err := c.ServeNew("KeyValueStore", func(s *grpc.Server) { |
There was a problem hiding this comment.
(see answer wrt pipeline runner)
ettec
force-pushed
the
ks-146/standard-capability
branch
from
66e516b
to
18a54f6
Compare
ettec
force-pushed
the
ks-146/standard-capability
branch
from
18a54f6
to
21b0904
Compare
ettec
force-pushed
the
ks-146/standard-capability
branch
from
3be4eea
to
5fccd04
Compare
No description provided.