Propagate pre-commit errors when running go commands #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tateexon
force-pushed
the
propagate-go-issues-in-pre-commit
branch
from
39ef079
to
0600bd3
Compare
kalverra
approved these changes
Apr 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff happening inside of the bash -c "..." doesn't push the exit code outside so we weren't actually getting the errors. Changed these to loops instead.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
These changes enhance development tooling and workflow automation by refining the execution of Go-related hooks, adding typo detection, and updating tool versions. This improves code quality and consistency across the project.
What
xargscommand with awhileloop to iterate over files. This change improves the readability and reliability of the script execution.cd -to return to the original directory, maintaining the expected working directory state after script execution.