[TT-1140] fix logical error

[Tofel]

logic in for loop was incorrect and the allowed message was still failing the test :/

---

Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes improve the semantics of the LogAllowed type by renaming it to WarnAboutAllowedMsgs, making its purpose clearer in the context of handling log messages. This change also includes a minor logic improvement in handling allowed log messages within the log file verification process.

What

• testreporters/reporter_model.go
  • Renamed the LogAllowed type to WarnAboutAllowedMsgs to clarify that it controls warnings about allowed messages.
    • Changed LogAllowed_Yes to WarnAboutAllowedMsgs_Yes and LogAllowed_No to WarnAboutAllowedMsgs_No to match the new type name.
  • Modified the NewAllowedLogMessage function parameter type from LogAllowed to WarnAboutAllowedMsgs to reflect the type change.
  • Improved handling of allowed log messages in the VerifyLogFile function by using a label (SCANNER_LOOP) for the loop, allowing for cleaner skipping of allowed messages after logging them (when configured to do so). This logic enhancement simplifies the control flow and makes the intent of skipping the rest of the processing for allowed messages more explicit.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube