Fix issue where supported network link did not work for certain netwo… #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacine-benichou
requested review from
dwightjl,
ritika-b,
aelmanaa and
thedriftofwords
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dwightjl
approved these changes
Jul 25, 2023
simkasss
pushed a commit
to simkasss/documentation
that referenced
this pull request
Jul 27, 2023
smartcontractkit#1415) * Fix issue where supported network link did not work for certain networks + Fix typos * Edits * Apply small syntax suggestion --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan>
dwightjl
added a commit
that referenced
this pull request
Sep 7, 2023
* filter data-feed by category * pagination wip * filter eth mainnet table * add search input * url sync with search * update placeholder * Token terminology update (#1414) * Vrf v2 cost calculator (#1353) * Create design of VRF v2 cost calculator * Add checkbox to have user choose method and compute parameters to compute vrf request cost * Finalize VRF Cost Calculator * Fix API url link * fix API URL issue when calling * Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled * Fix bug when previous data are not refreshed after changing chain and network in calculator * Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method * Cost calculator edits * Refactor rebase issues + Fix issues that make API calls for BNB fail * Fix issue where gas price input was not taken into account in request cost computation + Add maxCost computation in subscription method depending on gas lane chosen * Apply design suggestions + Fix gas price that formatted the value before the user finished typing * Syntax fix * Add verification gas row in cost table of subscription method + Apply small syntax suggestions * Edits * Add Caret svg to dropdown input * Writer edits * Lint fix --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Dwight Lyle <dwightjl@gmail.com> * Fix issue where supported network link did not work for certain netwo… (#1415) * Fix issue where supported network link did not work for certain networks + Fix typos * Edits * Apply small syntax suggestion --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> * fix tsconfig.json errors in vscode (#1416) * fix tsconfig.json errors in vscode * fix compile errors in solana pricefeeds off-chain-read.ts * Vrf v2 cost calculator (#1418) * Create design of VRF v2 cost calculator * Finalize VRF Cost Calculator * Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled * Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method * Cost calculator edits * Refactor rebase issues + Fix issues that make API calls for BNB fail * Fix Arbitrum computation issue by adding LINK Premium and price feed + Add L1 Gas Price input field to table when network is Arbitrum * Fix API url + edits * Fix issue when L1 gas price estimate could be undefined when switching networks * Writer edits --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Dwight Lyle <dwightjl@gmail.com> * add query parameters * close dropdown on click outside * flexible search box * reset search and categories on network select * typecheck * fix queryString usage --------- Co-authored-by: Dwight Lyle <dwightjl@gmail.com> Co-authored-by: yacine-benichou <78235417+yacine-benichou@users.noreply.github.com> Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Amine E <aelmanaa@users.noreply.github.com>
dorianbayart
pushed a commit
to dorianbayart/documentation
that referenced
this pull request
Dec 25, 2023
* filter data-feed by category * pagination wip * filter eth mainnet table * add search input * url sync with search * update placeholder * Token terminology update (smartcontractkit#1414) * Vrf v2 cost calculator (smartcontractkit#1353) * Create design of VRF v2 cost calculator * Add checkbox to have user choose method and compute parameters to compute vrf request cost * Finalize VRF Cost Calculator * Fix API url link * fix API URL issue when calling * Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled * Fix bug when previous data are not refreshed after changing chain and network in calculator * Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method * Cost calculator edits * Refactor rebase issues + Fix issues that make API calls for BNB fail * Fix issue where gas price input was not taken into account in request cost computation + Add maxCost computation in subscription method depending on gas lane chosen * Apply design suggestions + Fix gas price that formatted the value before the user finished typing * Syntax fix * Add verification gas row in cost table of subscription method + Apply small syntax suggestions * Edits * Add Caret svg to dropdown input * Writer edits * Lint fix --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Dwight Lyle <dwightjl@gmail.com> * Fix issue where supported network link did not work for certain netwo… (smartcontractkit#1415) * Fix issue where supported network link did not work for certain networks + Fix typos * Edits * Apply small syntax suggestion --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> * fix tsconfig.json errors in vscode (smartcontractkit#1416) * fix tsconfig.json errors in vscode * fix compile errors in solana pricefeeds off-chain-read.ts * Vrf v2 cost calculator (smartcontractkit#1418) * Create design of VRF v2 cost calculator * Finalize VRF Cost Calculator * Fix total cost output bugs + Add chain icons next to chain name in dropdown + Solve dropdown issue that didn't show on click when input is filled * Fix responsive design issues + Add icons next to network options in dropdown menu + Fix issue where data wre not fetched from API when changing vrf method * Cost calculator edits * Refactor rebase issues + Fix issues that make API calls for BNB fail * Fix Arbitrum computation issue by adding LINK Premium and price feed + Add L1 Gas Price input field to table when network is Arbitrum * Fix API url + edits * Fix issue when L1 gas price estimate could be undefined when switching networks * Writer edits --------- Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Dwight Lyle <dwightjl@gmail.com> * add query parameters * close dropdown on click outside * flexible search box * reset search and categories on network select * typecheck * fix queryString usage --------- Co-authored-by: Dwight Lyle <dwightjl@gmail.com> Co-authored-by: yacine-benichou <78235417+yacine-benichou@users.noreply.github.com> Co-authored-by: Yacine Benichou <yacine@mb-q1g67f3cp6.lan> Co-authored-by: Amine E <aelmanaa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In https://docs.chain.link/vrf/v2/estimating-costs, when clicking on the supported networks link after selecting a network, the link does not directly go to the network chosen by the user. Also, There are some typos for the subscription method
Changes