Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e integration tests more usable by injecting secrets #245

Closed
krebernisak opened this issue Jan 18, 2021 · 1 comment
Closed

Make e2e integration tests more usable by injecting secrets #245

krebernisak opened this issue Jan 18, 2021 · 1 comment

Comments

@krebernisak
Copy link
Contributor

krebernisak commented Jan 18, 2021

Integration tests, like they are currently set up, are not too usable. We would like to start integration tests for all adapters at once, but how do we then inject a different API key to each one?

One possible solution would be to have a secrets.json configured with all secrets required for integration tests. Then every test can read from there.

For CI runs we could have an encrypted secrets.json.gpg file that gets decrypted and provided to the test suite. Documentation on this workflow can be found here.

Originally posted by @krebernisak in #218 (comment)

@krebernisak krebernisak changed the title Make integration tests more usable by injecting API keys and other secrets Make e2e integration tests more usable by injecting secrets Jan 18, 2021
@GMSteuart
Copy link

GMSteuart commented Jun 24, 2021

@krebernisak has consideration gone into a way of generalizing the creation of mock api requests to be used before working on api key integration development?

Edit: I see that issue 247 addresses this. I will be looking to see if there is an open issue regarding DRY test cases being moved to the root test runner.

@boxhock boxhock closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants