Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make integration tests more usable by mocking HTTP requests #247

Closed
krebernisak opened this issue Jan 18, 2021 · 1 comment
Closed

Make integration tests more usable by mocking HTTP requests #247

krebernisak opened this issue Jan 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@krebernisak
Copy link
Contributor

Instead of using Requester static functions to make HTTP requests, we would like to rewrite this functionality as an HTTP module object that gets injected into the adapter, and as such can be easily mocked in tests.

This will enable easier tests, better test coverage, and running more tests in the CI environment, increasing the overall codebase safety.
@krebernisak krebernisak added the enhancement New feature or request label Jan 18, 2021
@GMSteuart GMSteuart mentioned this issue Jun 24, 2021
Closed
@boxhock
Copy link
Contributor

boxhock commented Jan 18, 2022

Integration tests are now using mocks

@boxhock boxhock closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krebernisak @boxhock