[Feature] COVID tracker adapter #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2020 13:46
justinkaseman
force-pushed
the
feature/covid
branch
from
48f2b09
to
817626d
Compare
|
We should add this adapter to the release workflow ( |
thodges-gh
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new adapter for COVID tracker's API (https://covidtracking.com/data/api)
This adapter is dynamic in that it takes in a
fieldparam for the data field to return and an optionaldatefield for accessing historical COVID data.Caveats
While testing validation I noticed that a test that returns a
400error that is put in the'error calls @integration'group still passes. Not sure if this is a repository wide issue - needs further testing.Ticket
https://www.pivotaltracker.com/story/show/175417790