Feature/logger

[justinkaseman]

Description

Node operator's log files have been growing very large. The Coin Paprika adapter for example had a >100Gb logfile.

This PR removes the log emitted when a response is returned to a request. Logs will still be shown on error or when LOG_LEVEL="debug".

Additionally some other logs that should probably be better served to debug level logs are changed to be so.

Ticket

#176137608

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[justinkaseman]

Addresses #204 that was experienced when using the Node.js Error class:

throw new Error(xxxx)

[justinkaseman]

@krebernisak Left some reasoning on why I made certain changes

[RodrigoAD]

I've been playing with it, this is great. Just something I noticed, when there's an internal error, this is sent to the client as well. I don't know if this is the behavior we want

[justinkaseman]

I've been playing with it, this is great. Just something I noticed, when there's an internal error, this is sent to the client as well. I don't know if this is the behavior we want

I was wondering about which behaviour we want there too. My thought process is that we are open source and want to empower people to debug on their own. @krebernisak thoughts? This is related to that first change that you requested.

[krebernisak]

My thoughts are that we should handle most/all of errors, output them with correct status codes and appropriate messages. We have work to do here.

Internal errors should be caught, mapped to a HTTP 500 status code and construct an appropriate message. Something like Internal Server Error: ${error.name}. Then if we are in dev env (NODE_ENV=development) or some other verbose/debug flag is set, we dump the whole internal error on the output, as an underlying cause to be investigated.

[justinkaseman]

My thoughts are that we should handle most/all of errors, output them with correct status codes and appropriate messages. We have work to do here.

Internal errors should be caught, mapped to a HTTP 500 status code and construct an appropriate message. Something like Internal Server Error: ${error.name}. Then if we are in dev env (NODE_ENV=development) or some other verbose/debug flag is set, we dump the whole internal error on the output, as an underlying cause to be investigated.

@krebernisak Well said for a direction forward. Agreed that there is more work to do here with what response the user receives.

I reverted the code that had requested changes, leaving this PR to be:

• adding the verbose/debug internal error dump
• and setting most logs to be verbose/debug level to keep node operator log files small.

[krebernisak]

Thanks, @justinkaseman!