-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/finage v3 uk etf #2798
Merged
Merged
Feature/finage v3 uk etf #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9918de6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Soak test for finage-test succeeded
|
alecgard
reviewed
Jun 7, 2023
✔️ Soak test for finage-test succeeded
|
alecgard
reviewed
Jun 7, 2023
alecgard
approved these changes
Jun 7, 2023
✔️ Soak test for finage-test succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #DF-18915
Description
Add uk_etf endpoint to finage V3. The websocket endpoint does not return a message on initial connection, so adapter may return 504 errors because it did not receive a WS message. After the adapter receives the first ws message from finage, it'll correctly return an answer.
Changes
Steps to Test
WS_ENABLED=false
, andyarn build && yarn start
WS_ENABLED=true
and sending request from step 2Quality Assurance
<ADAPTER_PACKAGE>/schemas/env.json
and<ADAPTER_PACKAGE>/README.md
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Clubhouse/Shortcut