Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coinbase Prime adapter #3176

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Add Coinbase Prime adapter #3176

merged 2 commits into from
Feb 5, 2024

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Feb 5, 2024

Closes PDI-2304

Description

Added an adapter to interface with the Coinbase Prime API.

Changes

  • Added coinbase-prime adapter

Steps to Test

  1. yarn test packages/sources/coinbase-prime/test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: da72e9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/coinbase-prime-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@amit-momin amit-momin merged commit cb3e120 into main Feb 5, 2024
7 of 8 checks passed
@amit-momin amit-momin deleted the feature/coinbase-prime branch February 5, 2024 23:52
@github-actions github-actions bot mentioned this pull request Feb 5, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably update this to 16.11.68 like in the other adapters to avoid pushing this extra dep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point! I can open a follow up PR to clean this up.

rateLimiting: {
tiers: {
default: {
rateLimit1s: 25,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels maybe a little overkill, any idea how often we'd expect updates on the coinbase side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably is for a single asset in a single portfolio but we usually configure whatever the data provider's doc mention. If for any reason in the future there are requests for other assets or portfolios, all of the requests would share this rate limit so this helps future-proof the adapter too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants