-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coinbase Prime adapter #3176
Conversation
🦋 Changeset detectedLatest commit: da72e9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could probably update this to 16.11.68 like in the other adapters to avoid pushing this extra dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! I can open a follow up PR to clean this up.
rateLimiting: { | ||
tiers: { | ||
default: { | ||
rateLimit1s: 25, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels maybe a little overkill, any idea how often we'd expect updates on the coinbase side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably is for a single asset in a single portfolio but we usually configure whatever the data provider's doc mention. If for any reason in the future there are requests for other assets or portfolios, all of the requests would share this rate limit so this helps future-proof the adapter too.
Closes PDI-2304
Description
Added an adapter to interface with the Coinbase Prime API.
Changes
coinbase-prime
adapterSteps to Test
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.