Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/DF-19863 composite PoR using coinbase-prime wallets endpoint #3282

Merged
merged 10 commits into from
May 2, 2024

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented May 2, 2024

Closes #DF-19863

Description

Added wallets endpoint to coinbase-prime adapter
Added this new coinbase-prime wallets endpoint as an option in the proof-of-reserves composite stack as address list fetcher

Changes

  • added wallets endpoint to coinbase-prime adapter
  • added necessary plumbing to set it up in the proof-of-reserves composite EA

Steps to Test

  1. (from root) yarn test coinbase-prime
  2. using proof-of-reserves setup with coinbase-prime and por-indexer, ensure the coinbase-prime balance endpoint returns data that is roughly in line with the final composite stack result

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested review from karen-stepanyan and a team May 2, 2024 05:11
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: cfcff61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/proof-of-reserves-adapter Minor
@chainlink/coinbase-prime-adapter Minor
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

karen-stepanyan
karen-stepanyan previously approved these changes May 2, 2024
Copy link
Collaborator

@karen-stepanyan karen-stepanyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Left few minor comments, non are blocking tho

Copy link
Contributor

@austinborn austinborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments but nothing blocking, looks good!

packages/sources/coinbase-prime/src/endpoint/wallets.ts Outdated Show resolved Hide resolved
packages/sources/coinbase-prime/src/endpoint/wallets.ts Outdated Show resolved Hide resolved
packages/sources/coinbase-prime/src/transport/wallets.ts Outdated Show resolved Hide resolved
austinborn
austinborn previously approved these changes May 2, 2024
@mmcallister-cll mmcallister-cll merged commit b8a758c into main May 2, 2024
8 checks passed
@mmcallister-cll mmcallister-cll deleted the feat/DF-19863-composite-coinbase branch May 2, 2024 21:42
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants