-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/DF-19863 composite PoR using coinbase-prime wallets endpoint #3282
Conversation
…-of-reserves composite EA
🦋 Changeset detectedLatest commit: cfcff61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Left few minor comments, non are blocking tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments but nothing blocking, looks good!
Closes #DF-19863
Description
Added
wallets
endpoint to coinbase-prime adapterAdded this new coinbase-prime
wallets
endpoint as an option in the proof-of-reserves composite stack as address list fetcherChanges
wallets
endpoint to coinbase-prime adapterSteps to Test
yarn test coinbase-prime
balance
endpoint returns data that is roughly in line with the final composite stack resultQuality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.