Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github action version bumps #3299

Merged
merged 17 commits into from
May 21, 2024
Merged

chore: github action version bumps #3299

merged 17 commits into from
May 21, 2024

Conversation

erikburt
Copy link
Contributor

@erikburt erikburt commented May 21, 2024

Description

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Node16 has been out of support since September 2023. As a result we have started the deprecation process of Node16 for GitHub Actions. We plan to migrate all actions to run on Node20 by Spring 2024.
Following on from our warning in workflows using Node16 we will start enforcing the use of Node20 rather than Node16 on the 3rd of June.

There is one more dependency to be updated to node20. Will fix that once complete.

Changes

  • Updated all actions dependencies to their latest
  • Use softprops/action-gh-release instead of actions/create-release (deprecated/archived)
  • Formatting, cleanup comments

Steps to Test

Let workflows run.

Quality Assurance

  • (N/A) If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • (N/A) If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • (N/A) If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • (N/A) All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

RE-2561

@erikburt erikburt requested a review from austinborn May 21, 2024 19:08
@erikburt erikburt self-assigned this May 21, 2024
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 16c465a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@austinborn
Copy link
Contributor

Nice, thank you for this!

@erikburt erikburt merged commit 609467b into main May 21, 2024
7 checks passed
@erikburt erikburt deleted the chore/update-github-actions branch May 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants